Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secrets/azurekeyvault: Add support for private clouds (Azure Stack) #2997

Merged
merged 1 commit into from May 13, 2021

Conversation

sebtelko
Copy link
Contributor

@sebtelko sebtelko commented May 12, 2021

This adds support for using Key Vault with Azure Stack Hub.

This PR makes the regexp used for parsing the Key Vault key id less strict about the key vault URI, allowing URIs on the form: https://vault.<region>.<fqdn>/.

Fixes #2995.

This commit makes the regexp used for parsing the Key Vault key id less strict
about the key vault URI, allowing URIs on the form:
https://vault.<region>.<fqdn>/.

This adds support for using Key Vault with Azure Stack Hub.
@google-cla
Copy link

google-cla bot commented May 12, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no Cannot accept contribution until Google CLA is signed. label May 12, 2021
@sebtelko
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes Google CLA has been signed! and removed cla: no Cannot accept contribution until Google CLA is signed. labels May 12, 2021
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #2997 (fc6be32) into master (5f19477) will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2997      +/-   ##
==========================================
+ Coverage   69.33%   69.46%   +0.12%     
==========================================
  Files         111      111              
  Lines       11628    11628              
==========================================
+ Hits         8062     8077      +15     
+ Misses       2899     2883      -16     
- Partials      667      668       +1     
Impacted Files Coverage Δ
secrets/azurekeyvault/akv.go 46.39% <ø> (+2.06%) ⬆️
blob/s3blob/s3blob.go 89.47% <0.00%> (+0.52%) ⬆️
runtimevar/awssecretsmanager/awssecretsmanager.go 74.19% <0.00%> (+2.41%) ⬆️
server/health/sqlhealth/sqlhealth.go 78.37% <0.00%> (+21.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f19477...fc6be32. Read the comment docs.

@vangent vangent merged commit f004cb7 into google:master May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA has been signed!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

secrets/azurekeyvault: Add support for private clouds (Azure Stack Hub)
2 participants