Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blob/azblob: Pass nil instead of an empty map for tags on Copy operation #2989

Merged
merged 9 commits into from Apr 19, 2021

Conversation

vangent
Copy link
Contributor

@vangent vangent commented Apr 16, 2021

Cloned from #2988 by @leezen, because it requires updating some golden files

Fixes #2982

Providing an empty map ends up causing the underlying SDK to want to have permissions to write tags against the destination blob. However, we don't actually need this permission since we're not really writing any tags. Instead, we should just pass in nil.

@leezen
Copy link

leezen commented Apr 16, 2021

@vangent Thanks for bringing this over!

@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #2989 (1488303) into master (7b4db4c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2989      +/-   ##
==========================================
+ Coverage   69.55%   69.57%   +0.01%     
==========================================
  Files         111      111              
  Lines       11615    11614       -1     
==========================================
+ Hits         8079     8080       +1     
+ Misses       2867     2865       -2     
  Partials      669      669              
Impacted Files Coverage Δ
blob/azureblob/azureblob.go 77.71% <100.00%> (-0.05%) ⬇️
blob/s3blob/s3blob.go 89.47% <0.00%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b4db4c...1488303. Read the comment docs.

@vangent vangent merged commit 448a545 into google:master Apr 19, 2021
@vangent vangent deleted the azb branch April 19, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA has been signed!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

blob/azblob: Permissions error when using SAS Token
3 participants