server/requestlog: responseStats should implement http.Hijacker #2737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
responseStats should support connection hijacking if underlying response writer does. Signed-off-by: Alex Snast <alexsn@fb.com>
|
Currently websocket upgrades fails when using requestlog middleware as the wrapped response writer doesn't implement |
Codecov Report
@@ Coverage Diff @@
## master #2737 +/- ##
==========================================
+ Coverage 68.29% 68.33% +0.03%
==========================================
Files 115 115
Lines 13274 13281 +7
==========================================
+ Hits 9065 9075 +10
+ Misses 3548 3544 -4
- Partials 661 662 +1
Continue to review full report at Codecov.
|
vangent
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
responseStats should support connection hijacking if underlying response
writer does.
Signed-off-by: Alex Snast alexsn@fb.com