Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blob: Let readFromWriteTo return the original err #2735

Merged
merged 1 commit into from Jan 31, 2020

Conversation

petr-tichy
Copy link
Contributor

Allows the caller to detect the error type instead of returning a
formatted string

Allows the caller to detect the error type instead of returning a
formatted string
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Cannot accept contribution until Google CLA is signed. label Jan 31, 2020
@codecov
Copy link

codecov bot commented Jan 31, 2020

Codecov Report

Merging #2735 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2735      +/-   ##
==========================================
+ Coverage   68.34%   68.35%   +<.01%     
==========================================
  Files         115      115              
  Lines       13274    13274              
==========================================
+ Hits         9072     9073       +1     
+ Misses       3542     3539       -3     
- Partials      660      662       +2
Impacted Files Coverage Δ
blob/blob.go 89.85% <0%> (ø) ⬆️
runtimevar/filevar/filevar.go 85.32% <0%> (-1.84%) ⬇️
pubsub/pubsub.go 91.87% <0%> (-1.57%) ⬇️
server/health/sqlhealth/sqlhealth.go 80.95% <0%> (+19.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88e0487...2ed32ae. Read the comment docs.

@petr-tichy
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Google CLA has been signed! and removed cla: no Cannot accept contribution until Google CLA is signed. labels Jan 31, 2020
@vangent vangent merged commit d780487 into google:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA has been signed!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants