docstore: fix batch Creates #2726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2726 +/- ##
==========================================
- Coverage 68.28% 68.23% -0.06%
==========================================
Files 115 115
Lines 13273 13273
==========================================
- Hits 9064 9057 -7
- Misses 3548 3554 +6
- Partials 661 662 +1
Continue to review full report at Codecov.
|
deniswg
suggested changes
Jan 17, 2020
| for _, a := range actions { | ||
| if a.Kind == Get { | ||
| if a.Key == nil { |
There was a problem hiding this comment.
I believe Key is not necessarily nil, it could be empty string. Probably better check a.Kind == Create
jba
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2725.
As described in the bug, a batched set of actions with multiple Create actions would drop all but one of the Creates. This is because an internal grouping operation used to order actions so that Gets and Writes for the same key are in an appropriate order uses
Keyas a map key. Create actions may have anilKey, so only one survived.To fix this, keep a separate slice of actions with
nilKeys during the grouping, and append them to the "write" group at the end.