From 4b5c953f1c40377dd11cc04f3088a81dd9f7791c Mon Sep 17 00:00:00 2001 From: Max Burke Date: Tue, 6 Dec 2022 12:45:36 -0800 Subject: [PATCH 1/2] Restore public visibility of previously-public fields --- rust/flatbuffers/src/table.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rust/flatbuffers/src/table.rs b/rust/flatbuffers/src/table.rs index f5001f6d1ca..c3242193ae0 100644 --- a/rust/flatbuffers/src/table.rs +++ b/rust/flatbuffers/src/table.rs @@ -20,8 +20,8 @@ use crate::vtable::VTable; #[derive(Clone, Copy, Debug, PartialEq, Eq)] pub struct Table<'a> { - buf: &'a [u8], - loc: usize, + pub buf: &'a [u8], + pub loc: usize, } impl<'a> Table<'a> { From 09cb9595af8ad6f184914a669980cd7ce53435bf Mon Sep 17 00:00:00 2001 From: Max Burke Date: Wed, 7 Dec 2022 21:23:11 -0800 Subject: [PATCH 2/2] code review feedback --- rust/flatbuffers/src/table.rs | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/rust/flatbuffers/src/table.rs b/rust/flatbuffers/src/table.rs index c3242193ae0..d3c296bb316 100644 --- a/rust/flatbuffers/src/table.rs +++ b/rust/flatbuffers/src/table.rs @@ -20,11 +20,21 @@ use crate::vtable::VTable; #[derive(Clone, Copy, Debug, PartialEq, Eq)] pub struct Table<'a> { - pub buf: &'a [u8], - pub loc: usize, + buf: &'a [u8], + loc: usize, } impl<'a> Table<'a> { + #[inline] + pub fn buf(&self) -> &'a [u8] { + self.buf + } + + #[inline] + pub fn loc(&self) -> usize { + self.loc + } + /// # Safety /// /// `buf` must contain a `soffset_t` at `loc`, which points to a valid vtable