Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS] Transpiled flatbuffers mjs directory do not contain expected modules #7814

Closed
bjornharrtell opened this issue Feb 5, 2023 · 1 comment
Closed

[TS] Transpiled flatbuffers mjs directory do not contain expected modules #7814

bjornharrtell opened this issue Feb 5, 2023 · 1 comment

Comments

@bjornharrtell
Copy link
Collaborator

Transpilation target seems off,

Older version at https://unpkg.com/browse/flatbuffers@23.1.4/mjs/builder.js looks ok. New version at https://unpkg.com/browse/flatbuffers@23.1.21/mjs/builder.js looks like commonjs.. perhaps?

This seems to be cause of this potential problem in dependents:

ByteBuffer is not exported by node_modules/flatbuffers/mjs/flatbuffers.js
@bjornharrtell bjornharrtell mentioned this issue Feb 6, 2023
Merged
@bjornharrtell bjornharrtell changed the title Transpiled flatbuffers mjs directory do not contain expected modules [TS] Transpiled flatbuffers mjs directory do not contain expected modules Feb 6, 2023
@bjornharrtell
Copy link
Collaborator Author

This regressed due to #7510.

@bjornharrtell bjornharrtell mentioned this issue Feb 6, 2023
Merged
4 tasks
@domoritz domoritz mentioned this issue Feb 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bjornharrtell