Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlatBuffers Version 22.9.24 #7547

Merged
merged 2 commits into from Sep 27, 2022
Merged

FlatBuffers Version 22.9.24 #7547

merged 2 commits into from Sep 27, 2022

Conversation

dbaileychess
Copy link
Collaborator

Updated version for new release.

@aardappel
Copy link
Collaborator

Woah!

Personally I love this, as I've always said semver is meaningless (for FlatBuffers anyway, where indicating what exactly is "breaking" across so many language implementations you can never get right), and dates are indeed the most amount of useful meaning you can pack into a version.

But I suspect some other maintainers / users may be unhappy with this.. we should gather some feedback before merging this?

@mustiikhalil
Copy link
Collaborator

For me, I don't mind the change, since it will make the release process for the swift lib much smoother, however the issue might arise when trying to use SPM with 22.09.14-bc44fad since i'm not sure if that would be accepted within xcode.

ref: https://developer.apple.com/documentation/xcode/publishing-a-swift-package-with-xcode

@dbaileychess
Copy link
Collaborator Author

@mustiikhalil Thanks for the info. The -bc44fad ending is valid semvar (https://semver.org/), so tooling should be able to handle it.

@aardappel
Copy link
Collaborator

@aardappel
Copy link
Collaborator

aardappel commented Sep 25, 2022

https://github.com/google/flatbuffers/wiki/Versioning is great.

I'd almost argue to forgo the git hash though.. 2 releases on 1 day is super rare, and if it ever happens, I'd simply use the date of the next day.. by the time the release has perculated thru all package managers etc the date is probably true. And since this date is a version, not used as a real date by package managers etc, there shouldn't be any "date is in the future" errors.

@CasperN
Copy link
Collaborator

CasperN commented Sep 27, 2022

Are we sure all tooling that we work with will allow semver jumps, e.g. from "22.09.27" to "22.12.12" without going through "22.10.0" and "22.11.0" first?

@aardappel
Copy link
Collaborator

I don't see why any tool would require to "see" all consecutive numbers..

Either way, if there is such a tool, we're about to find out with a jump from 2 to 22 :)

@dbaileychess dbaileychess merged commit 76ddae0 into google:master Sep 27, 2022
mustiikhalil pushed a commit to mustiikhalil/flatbuffers that referenced this pull request Sep 27, 2022
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Sep 28, 2022
…t script [1]

(Pushed to [community-testing] for testing if the new version scheme [2] breaks anything)

[1] google/flatbuffers#7529
[2] google/flatbuffers#7547


git-svn-id: file:///srv/repos/svn-community/svn@1315604 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Sep 28, 2022
…t script [1]

(Pushed to [community-testing] for testing if the new version scheme [2] breaks anything)

[1] google/flatbuffers#7529
[2] google/flatbuffers#7547

git-svn-id: file:///srv/repos/svn-community/svn@1315604 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants