Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust Alignment #7531

Closed
CasperN opened this issue Sep 13, 2022 · 2 comments
Closed

Rust Alignment #7531

CasperN opened this issue Sep 13, 2022 · 2 comments
Labels

Comments

@CasperN
Copy link
Collaborator

CasperN commented Sep 13, 2022

The Rust Flatbuffers library currently relies on Rust's notion of alignment, which is platform dependent. We should audit/remove all use of align_of::<T>() and use our own trait for flatbuffers types.

Note that since &[u8] is alignment 1 in Rust, our generated Rust code doesn't assume things are aligned, but we may create unaligned buffers that will be read on other languages/platforms

Discovered in #7015
Blocking #7103

@github-actions
Copy link

This issue is stale because it has been open 6 months with no activity. Please comment or label not-stale, or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Mar 14, 2023
@github-actions
Copy link

This issue was automatically closed due to no activity for 6 months plus the 14 day notice period.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant