Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS/JS] New flatbuffers bundle not exactly equivalent to old single file #7512

Closed
bjornharrtell opened this issue Sep 7, 2022 · 2 comments
Closed

[TS/JS] New flatbuffers bundle not exactly equivalent to old single file #7512

bjornharrtell opened this issue Sep 7, 2022 · 2 comments

Comments

@bjornharrtell
Copy link
Collaborator

A way to create a single file flatbuffers.js was done in #7449.

I however noted when doing #7510 (comment) that it's not exactly equivalent. The old https://unpkg.com/flatbuffers@1.12.0/js/flatbuffers.js exports a symbol named flatbuffers where as the new one exports the content of flatbuffers.
@bjornharrtell bjornharrtell changed the title New flatbuffers bundle not exactly equivalent to old single file [TS/JS] New flatbuffers bundle not exactly equivalent to old single file Sep 7, 2022
@bjornharrtell bjornharrtell mentioned this issue Sep 7, 2022
Closed
@bjornharrtell
Copy link
Collaborator Author

Not sure about this now. I realize the old file actually both export flatbuffers symbol and at the same time defines it as a global. That's kind of a "bastard" module.

But, a possible solution in #7513.

@bjornharrtell
Copy link
Collaborator Author

Not interested anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bjornharrtell