New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor test.cpp #7487
Refactor test.cpp #7487
Conversation
This is the time for the following
On my computer, which is pretty beefy. With this refactor:
Without this refactor (at head):
So ~3.5 seconds savings overall (~15% speedup) just for a refactor. |
It's probably a good idea to split these up.. if anything, I question the organization, either they should all be named Also, not sure I see the utility of having a headerfile for each, since there's nothing in them.. I'd make 1 test function per |
The Google style is to postfix In terms of
|
Splits
tests/test.cpp
into various modules to reduce compilation time.This of course, doesn't decrease the amount of work, but it allows parallelized builds to go much faster. Especially on incremental rebuilds.
At least on my machine, it reduced the compilation time from 13s down to 5s, for this
test.cpp
in isolation. It is actually a tad bit lower than a file I created in this PR:monster_test.cpp
is 5.6s.I think the rest of this can be refactored more, but since it is no longer the biggest offending thing, I am going to devote my time to that: the
idl_parser.cpp