Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlatBuffers 3.0.0 tracking issue #6636

Open
aardappel opened this issue May 10, 2021 · 9 comments
Open

FlatBuffers 3.0.0 tracking issue #6636

aardappel opened this issue May 10, 2021 · 9 comments
Labels
not-stale Explicitly exempt marking this stale Release An issue involving a release of flatbuffers

Comments

@aardappel
Copy link
Collaborator

This is the tracking issue for the release after 2.0 (see #6353).

Please link from issues that should be resolved by the next release to this issue.

Any other release related discussion welcome here too, but for extensive discussion of some aspect of it please create new issues.

@aardappel
Copy link
Collaborator Author

@krojew made me aware there is actually a github feature for tracking releases: milestones.

It is here: https://github.com/google/flatbuffers/milestone/1

You can add issues/PRs to it directly.. this issue for general discussion of the release.

@dbaileychess
Copy link
Collaborator

Should we close this issue then?

@krojew
Copy link
Contributor

krojew commented May 11, 2021

It might be good for tracking release status for various languages. For example, I have no idea which languages have not been updated to 2.0.0 at the moment without such list.

@aardappel
Copy link
Collaborator Author

Yes, milestones have no associated discussion so let's leave this open. But no need to link issues here anymore, just use the milestone.

@dbaileychess dbaileychess added this to the Release 2.1 (or 3.0) milestone May 13, 2021
@dbaileychess
Copy link
Collaborator

Ok, I linked this to the milestone.

@github-actions
Copy link

This issue is stale because it has been open 6 months with no activity. Please comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Nov 12, 2021
@aardappel
Copy link
Collaborator Author

not-stale

@CasperN
Copy link
Collaborator

CasperN commented Feb 14, 2022

I'd like to make this issue a release tracker for 3.0.0 specifically, since there are some breaking changes planned for Rust APIs (#7103). It did take a few months to plan and execute last time, so perhaps we should start the discussion

@CasperN CasperN changed the title FlatBuffers 2.1 (or 3.0) tracking issue FlatBuffers 3.0.0 tracking issue Feb 14, 2022
@CasperN CasperN added the not-stale Explicitly exempt marking this stale label Feb 14, 2022
@dbaileychess dbaileychess added the Release An issue involving a release of flatbuffers label Feb 22, 2022
@CasperN
Copy link
Collaborator

CasperN commented May 31, 2022

@mustiikhalil found in #7269 that its possible for a type that doesn't have a (private) annotation to contain a type that does have such an annotation, effectively leaking the inner type to the world (and causing errors with the rather picky rust compiler). Before 3.0 we should change the --no-leak-private-annotation flag to --allow-leak-private-annotation and force users to migrate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-stale Explicitly exempt marking this stale Release An issue involving a release of flatbuffers
Projects
None yet
Development

No branches or pull requests

4 participants