Skip to content

Code review request #45

Closed
Closed
@cushon

Description

@cushon
Collaborator

Original issue created by eaftan@google.com on 2012-10-01 at 10:34 PM


I fixed a bug with the compiler in the case that we are trying to scan a compilation unit that hasn't had all of its classes attributed yet.

Previously I had assumed that flow() would be called once on each class; that turns out not to be the case. We now track which classes error-prone has seen, and we only scan a compilation unit when we've seen all of its contained classes.

Activity

cushon

cushon commented on Oct 31, 2014

@cushon
CollaboratorAuthor

Original comment posted by supertri@google.com on 2012-10-04 at 05:55 PM


(No comment entered for this change.)


Status:

cushon

cushon commented on Oct 31, 2014

@cushon
CollaboratorAuthor

Original comment posted by supertri@google.com on 2012-10-04 at 05:56 PM


(No comment entered for this change.)


Status: Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @cushon

        Issue actions

          Code review request · Issue #45 · google/error-prone