Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JDK 16-ea breakage: Symbol.isLocal was renamed to isDirectlyOrIndirectlyLocal #2105

Closed
cushon opened this issue Jan 14, 2021 · 0 comments · Fixed by #2113
Closed

JDK 16-ea breakage: Symbol.isLocal was renamed to isDirectlyOrIndirectlyLocal #2105

cushon opened this issue Jan 14, 2021 · 0 comments · Fixed by #2113

Comments

@cushon
Copy link
Collaborator

cushon commented Jan 14, 2021

e.g.

Error:  ./check_api/src/main/java/com/google/errorprone/fixes/SuggestedFixes.java:[314,14] cannot find symbol
  symbol:   method isLocal()

See: openjdk/jdk@47c180d#diff-9b6c5d86aacec00206bfcdbfc12caa41fbb0812426c4f2fd290c3fb1873a532fL442-R442
copybara-service bot pushed a commit that referenced this issue Jan 14, 2021
@cushon
Use @code instead of @link for a class not on the classpath
daceab9 
SKIP_COPYBARA =#2105
PiperOrigin-RevId: 351862466
@copybara-service copybara-service bot mentioned this issue Jan 14, 2021
Merged
copybara-service bot pushed a commit that referenced this issue Jan 14, 2021
@cushon
Update versions to HEAD-SNAPSHOT
a4f68ac 
following the example of e.g. Guava and Truth. Instead of pushing release and
SNAPSHOT versions to the main branch, we can commit them immediately before a
release and then push the tagged commit, but avoid cluttering up the main
branch or having to make the changes internally and wait for copybara.

SKIP_COPYBARA =#2105
PiperOrigin-RevId: 351867240
@copybara-service copybara-service bot mentioned this issue Jan 14, 2021
Merged
copybara-service bot pushed a commit that referenced this issue Jan 14, 2021
@cushon
Use @code instead of @link for a class not on the classpath
0c11dc0 
SKIP_COPYBARA =#2105
PiperOrigin-RevId: 351862466
copybara-service bot pushed a commit that referenced this issue Jan 15, 2021
@cushon
Symbol.isLocal was renamed in JDK 16
f85ef3f 
Fixes #2105

PiperOrigin-RevId: 351899795
@copybara-service copybara-service bot mentioned this issue Jan 15, 2021
Merged
copybara-service bot pushed a commit that referenced this issue Jan 15, 2021
@cushon
Symbol.isLocal was renamed in JDK 16
19cd51f 
Fixes #2105

PiperOrigin-RevId: 351899795
copybara-service bot pushed a commit that referenced this issue Jan 15, 2021
@cushon
Symbol.isLocal was renamed in JDK 16
379af83 
Fixes #2105

PiperOrigin-RevId: 351899795
stevie400 pushed a commit to HubSpot/error-prone that referenced this issue Jan 15, 2021
@cushon @stevie400
Symbol.isLocal was renamed in JDK 16
8ebe38a 
Fixes google#2105

PiperOrigin-RevId: 351903127
This was referenced Mar 13, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Symbol.isLocal was renamed in JDK 16 google/error-prone
1 participant
@cushon