Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dagger-android-processor still always enables formatting #3531

Closed
ZacSweers opened this issue Aug 12, 2022 · 3 comments
Closed

dagger-android-processor still always enables formatting #3531

ZacSweers opened this issue Aug 12, 2022 · 3 comments

Comments

@ZacSweers
Copy link

This line does not respect the value of the formatting compiler option.

I can take a shot at a PR if you're open to it

@ZacSweers
Copy link
Author

Went ahead and made one in #3532

@Chang-Eric
Copy link
Member

Thanks, I'll go ahead and patch in your PR and submit it. Unfortunately, our tooling is complex enough that it is easiest to just do it this way rather than have you actually submit the PR. You should be credited as the original author on the commit though. Thanks!

@Chang-Eric
Copy link
Member

Just updating for clarification, we actually decided to go another route and remove the formatting entirely since we don't format in Hilt and so adding a flag doesn't really feel worth it.

copybara-service bot pushed a commit that referenced this issue Aug 17, 2022
Fixes #3531.

RELNOTES=Remove formatting from dagger.android generated source. May be relevant for golden files.
PiperOrigin-RevId: 468278501
copybara-service bot pushed a commit that referenced this issue Aug 17, 2022
Fixes #3531.

RELNOTES=Remove formatting from dagger.android generated source. May be relevant for golden files.
PiperOrigin-RevId: 468278501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants