forked from square/dagger
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dagger generates code with wrong parameter names for member injection #3476
Comments
The same issue. In the case of injecting in a custom class.
It didn't happen in 2.42.
|
Thanks for the repro! I should have a fix out today and we can do a 2.43.1 release next week. |
That would be wonderful. Thanks! |
1 task
The funny thing is I wasn't having an issue until 2.43, so had to downgrade to 2.42, I'll wait until 2.43.1 and try again. Thanks for the quick fixes y'all |
The fix works. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue is very similar to #3401. The bug for subcomponents is resolved, but there's still an issue with member injection. The generated code for member injection looks like this:
I've updated the sample here: https://github.com/vRallev/anvil/tree/ralf/dagger-bug Notice that the branch is
ralf/dagger-bug
. You should be able to reproduce the bug by running./gradlew test
. This issue happens with Dagger 2.43 and the latest snapshot.The text was updated successfully, but these errors were encountered: