Move PEMCertPool from CTFE package to x509util #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCutter
approved these changes
Apr 11, 2022
|
The whole of the "internals" of CTFE (such as the |
Currently many things indirectly depend on the entire CTFE package (including HTTP handlers and some flags) because they use the cert pool. For example, the ctclient CLI tool imports loglist, which imports ctfe. This is a large overkill, and brings irrelevant flags to the CLI tool. This change moves the cert pool type to x509util, because it's a wrapper around the x509 pool.
|
Updated changelog. |
2 tasks
pav-kv
added a commit
that referenced
this pull request
May 4, 2022
This change removes the dependency of x509util tests from ctfe/testonly package introduced in #903. There are 2 certificates copy-pasted between the two packages, but they don't strictly need to match, and having them independent is a bigger advantage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently many things indirectly depend on the entire CTFE package
(including HTTP handlers and some flags) because they use the cert pool.
For example, the
ctclientCLI tool importsloglist, which importsctfe.This is a large overkill, and brings irrelevant flags to the CLI tool.
This change moves the cert pool type to
x509util, because it's a wrapperaround the pool provided in the
x509package.Checklist