Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace juju/ratelimit with x/time/rate #800

Merged
merged 1 commit into from
May 3, 2022
Merged

Conversation

mjg59
Copy link
Contributor

@mjg59 mjg59 commented Apr 20, 2021

The consequences of the LGPL static linking exception in juju/ratelimit
aren't terribly well understood, and it's the only component in the
certificate-transparency chain that's not under something well-studied like
MIT or Apache. There's now ratelimit support in x/time, so porting over to
use that instead simplifies licensing analysis.

Checklist

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Apr 20, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@pphaneuf
Copy link
Contributor

"Your first contribution to a Google open source project"... 🤣

/gcbrun

@pphaneuf
Copy link
Contributor

Looks like you, er, need to sign the CLA?

@mjg59
Copy link
Contributor Author

mjg59 commented Apr 22, 2021

Yup, just blocked on legal for a moment.

@pphaneuf pphaneuf self-assigned this Apr 22, 2021
@pphaneuf pphaneuf self-requested a review April 22, 2021 09:05
@pav-kv
Copy link
Contributor

pav-kv commented Apr 27, 2022

Let's resurrect this PR.

@pav-kv
Copy link
Contributor

pav-kv commented Apr 28, 2022

/gcbrun

@pav-kv pav-kv force-pushed the master branch 2 times, most recently from ac0909b to 7cd367f Compare April 28, 2022 12:49
The consequences of the LGPL static linking exception in juju/ratelimit
aren't terribly well understood, and it's the only component in the
certificate-transparency chain that's not under something well-studied like
MIT or Apache. There's now ratelimit support in x/time, so porting over to
use that instead simplifies licensing analysis.
@pav-kv
Copy link
Contributor

pav-kv commented Apr 28, 2022

/gcbrun

@pav-kv
Copy link
Contributor

pav-kv commented Apr 28, 2022

@mjg59 The check still stays you haven't signed the CLA. Please do if you would still like this PR submitted. I rebased it on top of the current master so that it has no conflicts.

@mjg59
Copy link
Contributor Author

mjg59 commented Apr 29, 2022

CLA should now be signed

@mjg59
Copy link
Contributor Author

mjg59 commented Apr 29, 2022

Oh I see my corp email address isn't on file. I'll deal with that in the morning, sorry!

@mjg59
Copy link
Contributor Author

mjg59 commented May 2, 2022

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels May 3, 2022
@pav-kv
Copy link
Contributor

pav-kv commented May 3, 2022

@mjg59 Looks like the bot finally believed you, thanks :)

@pav-kv pav-kv merged commit 6957b35 into google:master May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants