Codelab module and codelab refactors #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l46kok
previously approved these changes
Jul 15, 2022
There was a problem hiding this comment.
Could we also update the examples with this new syntax? Either in this or in a separate PR
|
@l46kok good catch on updating the examples as well. Done. |
l46kok
reviewed
Jul 15, 2022
l46kok
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the codelab to be its own go-module and refactor the codelab solution to use
the latest features such as
cel.Variableandcel.Functionwhich both simplify the codeand perform more of the boilerplate tasks in the core CEL library rather than in user-
provided extensions.
Will update the public codelab to match post-submission as part of fixes for #553