Add the duration declarations in the new style when UTC is enabled #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the partial declaration causes improper dynamic dispatch
|
Thanks for addressing this. Tested in k8s side and it works as expected |
jcking
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the UTC fix is isolated to timestamps only the timestamp overloads were provided in the new style using
Function; however, this causes a problem with dynamic dispatch where the functions likegetHoursare split between timestamps and durations. The generated dynamic dispatch function was then receiving the call instead of theDurationobject resulting in ano such overloaderror.This has been remedied by declaring duration functions that share the same function name with the timestamp functions using the new style when the UTC time fix is enabled.