New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support formatting options when unparsing ASTs to strings #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/gcbrun |
jnthntatum
reviewed
Jun 30, 2022
jnthntatum
reviewed
Jun 30, 2022
jnthntatum
reviewed
Jun 30, 2022
jnthntatum
reviewed
Jun 30, 2022
jnthntatum
reviewed
Jun 30, 2022
/gcbrun |
jnthntatum
reviewed
Jul 7, 2022
This change adds formatting capability to unparser by introducing a new function named `UnparseFormatted`. The function will accept any number of `UnparserFormattingOption` to support adding new lines for any desired non-unary operators.
l46kok
changed the title
[Draft] Support formatting options when unparsing ASTs to strings (#293)
Support formatting options when unparsing ASTs to strings (#293)
Jul 7, 2022
/gcbrun |
TristonianJones
requested changes
Jul 7, 2022
l46kok
changed the title
Support formatting options when unparsing ASTs to strings (#293)
Support formatting options when unparsing ASTs to strings
Jul 7, 2022
PTAL |
TristonianJones
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds formatting capability to unparser by introducing new functional option
UnparseOption
.Unparse
function will accept any number ofUnparseOption
augment the behavior of unparsing an AST.This will allow support adding new lines for any desired non-unary operators when the length of a string exceeds the defined column limit.
Resolves #293