Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micro optimizations to type-testing utility functions. #518

Merged
merged 2 commits into from Mar 22, 2022

Conversation

TristonianJones
Copy link
Collaborator

@TristonianJones TristonianJones commented Mar 22, 2022

Small changes in type-testing utilities result in roughly 70x performance improvement. Overall the impact to individual expression evaluations is small, but noticeable ~5%:

BenchmarkInterpreter/complex-8                                935           846           -9.54%
BenchmarkInterpreter/complex_qual_vars-8                      783           732           -6.50%

@TristonianJones TristonianJones merged commit 0e2dde4 into google:master Mar 22, 2022
@TristonianJones TristonianJones deleted the micro-opt branch March 22, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants