Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting and spelling lint #511

Merged
merged 1 commit into from Mar 20, 2022
Merged

Conversation

kortschak
Copy link
Contributor

@kortschak kortschak commented Mar 19, 2022

This fixes a collection of spelling errors in user-facing and internal documentation and fixes a test-failing vet error (incorrect *testing.T method used), and fixes a style lint error.

There are also a bunch of non-fatal lint vet errors that are reasonably arguably false positive but which the Go team will not fix vet for (see golang/go#49350). I am happy to send fixes for those here as well if wanted.

# github.com/google/cel-go/codelab
codelab/codelab.go:60:2: fmt.Println arg list ends with redundant newline
codelab/codelab.go:70:2: fmt.Println arg list ends with redundant newline
codelab/codelab.go:85:2: fmt.Println arg list ends with redundant newline
codelab/codelab.go:95:2: fmt.Println arg list ends with redundant newline
codelab/codelab.go:104:2: fmt.Println arg list ends with redundant newline
codelab/codelab.go:115:2: fmt.Println arg list ends with redundant newline
codelab/codelab.go:126:2: fmt.Println arg list ends with redundant newline
codelab/codelab.go:140:2: fmt.Println arg list ends with redundant newline
# github.com/google/cel-go/codelab/solution
codelab/solution/codelab.go:60:2: fmt.Println arg list ends with redundant newline
codelab/solution/codelab.go:99:2: fmt.Println arg list ends with redundant newline
codelab/solution/codelab.go:132:2: fmt.Println arg list ends with redundant newline
codelab/solution/codelab.go:163:2: fmt.Println arg list ends with redundant newline
codelab/solution/codelab.go:219:2: fmt.Println arg list ends with redundant newline
codelab/solution/codelab.go:259:2: fmt.Println arg list ends with redundant newline
codelab/solution/codelab.go:328:2: fmt.Println arg list ends with redundant newline
codelab/solution/codelab.go:366:2: fmt.Println arg list ends with redundant newline

Please take a look.

* Fix spelling errors identified by gospel spelling linter.
* Fix lint issue in common/source_test.go identified by staticcheck.
* Fix vet issue in common/source_test.go idenitifiued by go vet.
@TristonianJones
Copy link
Collaborator

/gcbrun

@TristonianJones TristonianJones merged commit 9e07c99 into google:master Mar 20, 2022
@kortschak kortschak deleted the lint branch March 20, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants