"refType" may be "nil" and cause a crash

[nabice]

cel-go/common/types/provider.go

Lines 147 to 149 in f617eaf

	refType := td.ReflectType()
	// create the new type instance.
	value := reflect.New(refType.Elem())

[TristonianJones]

Hi @nabice could you provide a bit more context on what the type was and how it was provided? Generally speaking the code path in question should not have a nil reflected type unless the type itself was not provided properly. More details would be very helpful in triaging this report.

Thanks!

-Tristan

[nabice]

@TristonianJones
I am not sure if there is an error.
I use a code scanning tool and it tells me that ReflectType may return nil, as shown below:

cel-go/common/types/pb/type.go

Lines 93 to 98 in f617eaf

	func (td *TypeDescription) ReflectType() reflect.Type {
	if td.getMetadata().reflectedType == nil {
	return nil
	}
	return *td.getMetadata().reflectedType
	}

If it cannot be nil, please close this issue.

Sincerely.

[TristonianJones]

The ReflectType is nil in the case where the protobuf field is a map type, but the provider call only deals with proper protobuf object types. The code could probably use some cleanup, but shouldn't panic.