-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix mesos client panic while ExecutorPID is nill #3129
Conversation
fix mesos client panic while ExecutorPID is nill
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hi @Komey. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Thanks for the contribution - please approve the CLA - #3129 (comment) |
https://github.com/google/cadvisor/pull/3129/checks?check_run_id=6858815936 HI @bobbypage CLA has been approved |
Thanks! /ok-to-test |
/retest |
Thanks! |
From mesos-go ContainerStatus spec ExecutorPID can be null with *uint32.
This will cause nil pointer panic from line L111