Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mesos client panic while ExecutorPID is nill #3129

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

Komey
Copy link
Contributor

@Komey Komey commented Jun 13, 2022

From mesos-go ContainerStatus spec ExecutorPID can be null with *uint32.
This will cause nil pointer panic from line L111

// *
// Container related information that is resolved during container
// setup. The information is sent back to the framework as part of the
// TaskStatus message.
type ContainerStatus struct {
	ContainerID *ContainerID `protobuf:"bytes,4,opt,name=container_id,json=containerId" json:"container_id,omitempty"`
	// This field can be reliably used to identify the container IP address.
	NetworkInfos []NetworkInfo `protobuf:"bytes,1,rep,name=network_infos,json=networkInfos" json:"network_infos"`
	// Information about Linux control group (cgroup).
	CgroupInfo *CgroupInfo `protobuf:"bytes,2,opt,name=cgroup_info,json=cgroupInfo" json:"cgroup_info,omitempty"`
	// Information about Executor PID.
	ExecutorPID *uint32 `protobuf:"varint,3,opt,name=executor_pid,json=executorPid" json:"executor_pid,omitempty"`
}

@google-cla
Copy link

google-cla bot commented Jun 13, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@k8s-ci-robot
Copy link
Collaborator

Hi @Komey. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bobbypage
Copy link
Collaborator

/ok-to-test

@bobbypage
Copy link
Collaborator

Thanks for the contribution - please approve the CLA - #3129 (comment)

@Komey
Copy link
Contributor Author

Komey commented Aug 15, 2022

Thanks for the contribution - please approve the CLA - #3129 (comment)

https://github.com/google/cadvisor/pull/3129/checks?check_run_id=6858815936

HI @bobbypage CLA has been approved

@bobbypage
Copy link
Collaborator

Thanks!

/ok-to-test

@bobbypage bobbypage closed this Nov 9, 2022
@bobbypage bobbypage reopened this Nov 9, 2022
@bobbypage
Copy link
Collaborator

/retest

@bobbypage bobbypage merged commit ce07bb2 into google:master Nov 9, 2022
@bobbypage
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants