{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":52804750,"defaultBranch":"main","name":"breakpad","ownerLogin":"google","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2016-02-29T16:14:14.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/1342004?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1513901868.0","currentOid":""},"activityList":{"items":[{"before":"9dd7d3497e7f6d58e9459e0e6be28b1d4b41d35f","after":"69f9a4ef3ce4f5b40e3b202302a076cc2e96ec0b","ref":"refs/heads/main","pushedAt":"2024-05-23T18:39:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Fix format string for uint64_t and size_t data.\n\nChange-Id: I9086396561ea7870cfd55ab62c416d2944f0d46b\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5564823\nReviewed-by: Mike Frysinger ","shortMessageHtmlLink":"Fix format string for uint64_t and size_t data."}},{"before":"417f5dbd0af9f96ca3e5faa99f41c064b89b40fd","after":"9dd7d3497e7f6d58e9459e0e6be28b1d4b41d35f","ref":"refs/heads/main","pushedAt":"2024-05-23T16:55:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Add error handling for common failure case seen processing debug symbols\n\nPropagates error from ProcessDIEs to the top level where it can be\nhandled.\n\nChange-Id: Ib6ba171ff642a898c75233a3f70995837c6c0552\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5564423\nReviewed-by: Joshua Peraza ","shortMessageHtmlLink":"Add error handling for common failure case seen processing debug symbols"}},{"before":"54986d34d4611983243f8401563ff022b649afbf","after":"417f5dbd0af9f96ca3e5faa99f41c064b89b40fd","ref":"refs/heads/main","pushedAt":"2024-05-13T17:46:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"preserve NT_FILE note converting md to core\n\nbreakpad produced Minidumps have all the information needed to preserve the\nNT_FILE note that linux coredumps normally have, but are not currently\nincluded when converting using minidump-2-core. This adds a step to coredump\ngeneration to add the note to the coredump. This change allows for two\nimprovements when loading coredumps into gdb:\n\n1. for PIE code (default compilation now for gcc) gdb is now able to properly\nvalidate the PIE displacement and apply it to the debugging session, providing\nbetter stack trace quality.\n2. gdb can now pick up so symbol files automatically without relying on the\nscripting normally recommended by google for breakpad where add-symbol-file\nis used to manually load symbols.\n\nBug: https://crbug.com/google-breakpad/766\nChange-Id: I8cb25246dce0ae3492eedd6d3a4efcf1783d414d\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5463435\nReviewed-by: Mike Frysinger ","shortMessageHtmlLink":"preserve NT_FILE note converting md to core"}},{"before":"6fe410dcd5ddacec9554e8c217f3c37d0362da21","after":"54986d34d4611983243f8401563ff022b649afbf","ref":"refs/heads/main","pushedAt":"2024-05-10T00:30:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Adds a custom Module ID flag to dump_syms\n\nTEST=make check\nBUG=b:328511413\n\nChange-Id: I09d4c5e92213501b647311b804e65f272772bbaf\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5523975\nReviewed-by: Ivan Penkov \nReviewed-by: Ivan Penkov ","shortMessageHtmlLink":"Adds a custom Module ID flag to dump_syms"}},{"before":"f88a1aa2af1d1fd795716365245761b89041139d","after":"6fe410dcd5ddacec9554e8c217f3c37d0362da21","ref":"refs/heads/main","pushedAt":"2024-05-08T22:30:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Adds a Flag to Perserve Address Offset in dump_syms\n\nBy default, the .code section start address is normalized to zero,\nand subsequently the address of all functions and lines are adjusted\naccordingly. This change adds a command line flag that perserves the\noriginal addresses. This is a requirement for those that may wish to use\nthe crash resolver, but do not have a minidump file to work with (most commonly in firmware).\n\nTEST=make check\nBUG=b:328511413\n\nChange-Id: Id7c477196ffed7fd319029b28ed2607192249c6c\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5519154\nReviewed-by: Rob Barnes \nReviewed-by: Ivan Penkov \nReviewed-by: Ivan Penkov ","shortMessageHtmlLink":"Adds a Flag to Perserve Address Offset in dump_syms"}},{"before":"a8a43bad6fdb2d63b623862bea8f6bc959d8edc9","after":"f88a1aa2af1d1fd795716365245761b89041139d","ref":"refs/heads/main","pushedAt":"2024-04-24T17:29:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Use zlib's uncompress() to uncompress headers\n\nChange-Id: Ib785633b229d3f17534da9b0de93255e80fddd70\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5484086\nReviewed-by: Joshua Peraza ","shortMessageHtmlLink":"Use zlib's uncompress() to uncompress headers"}},{"before":"e5dc1f86b2defc8f76b56fb473b804e42e75c41d","after":"a8a43bad6fdb2d63b623862bea8f6bc959d8edc9","ref":"refs/heads/main","pushedAt":"2024-04-18T16:38:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Prefer to use .note.gnu.build-id section as ElfBuildId\n\nSummary:\nAndroid prefers `.note.gnu-build-id`[0] as BuildId than anyother PT_NOTE\nphdrs. This CL tries to read ElfBuildId from `.note.gnu.build-id` first\nto fix the BuildId mismatch issue between Android tombstone report and\nbreakpad symbol file.\n\ne.g\n```\nSection Headers:\n [Nr] Name Type Address Offset\n Size EntSize Flags Link Info Align\n [ 0] NULL 0000000000000000 00000000\n 0000000000000000 0000000000000000 0 0 0\n [ 1] .note.androi[...] NOTE 0000000000000270 00000270\n 0000000000000018 0000000000000000 A 0 0 4\n [ 2] .note.hwasan[...] NOTE 0000000000000288 00000288\n 000000000000001c 0000000000000000 A 0 0 4\n [ 3] .note.gnu.bu[...] NOTE 00000000000002a4 000002a4\n 0000000000000020 0000000000000000 A 0 0 4\n\n$ readelf -x .note.hwasan.globals\nHex dump of section '.note.hwasan.globals':\n 0x00000288 08000000 08000000 03000000 4c4c564d ............LLVM\n 0x00000298 00000000 98890100 409d0100 ........@...\n\n$ readelf -x .note.gnu.build-id\nHex dump of section '.note.gnu.build-id':\n 0x000002a4 04000000 10000000 03000000 474e5500 ............GNU.\n 0x000002b4 a4eb3625 c1db6452 1e881973 bfdff9bd ..6%..dR...s....\n```\n\nThe BuildId in tombstone:\n```\nlibartbase.so (BuildId: c7e463b51b0898d442269a421353bdbd)\n```\n\nBut the breakpad dump_syms got:\n```\nMODULE Linux arm64 000189989D40000100000000000000000 libartbase.so\nINFO CODE_ID 98890100409D0100\n`````\n\n[0]\nhttps://cs.android.com/android/platform/superproject/main/+/main:system/unwinding/libunwindstack/ElfInterface.cpp;l=423-427;drc=3d19fbcc09b1b44928639b06cd0b88f735cd988d\n\nChange-Id: I01e3514e0e2a1ea163c03093055284448ed4e89c\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5463566\nReviewed-by: Joshua Peraza ","shortMessageHtmlLink":"Prefer to use .note.gnu.build-id section as ElfBuildId"}},{"before":"a86123f1e7cc27d0e3de185467b3495cf0851f54","after":"e5dc1f86b2defc8f76b56fb473b804e42e75c41d","ref":"refs/heads/main","pushedAt":"2024-03-29T15:38:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Reduce logging during minidump processing\n\nChange-Id: Ie62795137770cff7cda7494c5527457b1e355897\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5402921\nReviewed-by: Ivan Penkov ","shortMessageHtmlLink":"Reduce logging during minidump processing"}},{"before":"76788faa4ef163081f82273bfca7fae8a734b971","after":"a86123f1e7cc27d0e3de185467b3495cf0851f54","ref":"refs/heads/main","pushedAt":"2024-03-19T20:45:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Fix some undefined behavior\n\nIt is undefined behavior to access mis-aligned pointers.\n\nChange-Id: I06f676c6a4b92a4bb58db76b8f23750d18148940\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5380937\nReviewed-by: Ivan Penkov ","shortMessageHtmlLink":"Fix some undefined behavior"}},{"before":"26666b80bac3254787976bb7be52db3f4a303663","after":"76788faa4ef163081f82273bfca7fae8a734b971","ref":"refs/heads/main","pushedAt":"2024-03-12T20:28:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Print better error messages in parts of CompilationUnit\n\nChange CompilationUnit::SkipAttribute() and\nCompilationUnit::ProcessOffsetBaseAttribute() to print the unknown form\ntypes they encounter.\n\nAlong the way, fix various formatting issues, stray trailing spaces, and\nupdate some NULLs to nullptrs.\n\nChange-Id: I5b3e72c9c6c9cb31e8a930e54418adb74b02f6c2\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5366242\nReviewed-by: Joshua Peraza ","shortMessageHtmlLink":"Print better error messages in parts of CompilationUnit"}},{"before":"f032e4c3b4eaef64432482cb00eb0c3df33cde48","after":"26666b80bac3254787976bb7be52db3f4a303663","ref":"refs/heads/main","pushedAt":"2024-03-12T17:46:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Check for failed seek when skipping x86 xstate data\n\nAfter reading minidump context with x86 xstate data, we seek past it, so\nthere needs to be a check to see that the seek operation did not fail.\n\nChange-Id: I8ed4394e452c435234116d97fd65856345cb618a\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5324600\nReviewed-by: Mike Frysinger ","shortMessageHtmlLink":"Check for failed seek when skipping x86 xstate data"}},{"before":"b48a2d4a8ed40024d38502db5aeabd3ab6876687","after":"f032e4c3b4eaef64432482cb00eb0c3df33cde48","ref":"refs/heads/main","pushedAt":"2024-02-22T00:22:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Addressing a potential integer underflow in minidump.cc and stackwalker_arm64.cc\n\nAlso, defining __STDC_FORMAT_MACROS before including \n\nChange-Id: Ia25c4353412ca70512efef5e98670687ab575750\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5310977\nReviewed-by: Joshua Peraza ","shortMessageHtmlLink":"Addressing a potential integer underflow in minidump.cc and stackwalk…"}},{"before":"a1169061a81adc88a326261294b0af9d53caf18a","after":"b48a2d4a8ed40024d38502db5aeabd3ab6876687","ref":"refs/heads/main","pushedAt":"2024-02-16T20:37:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Fix string format specifier\n\nSplit out from https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5300127/1..4/src/processor/range_map_unittest.cc#b507\n\nBug: None\nChange-Id: Iedc8508b6c123a54fdd1de2e2719dcd70adb03a6\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5300128\nReviewed-by: Ivan Penkov ","shortMessageHtmlLink":"Fix string format specifier"}},{"before":"f80f2888031b0570783011476a5e862fb7d848a1","after":"a1169061a81adc88a326261294b0af9d53caf18a","ref":"refs/heads/main","pushedAt":"2024-02-16T17:28:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Fix bad pointer comparison\n\nBug: None\nChange-Id: I7f3709ee7e8b7e9e938850b1bbe24925e3e03c9b\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5300127\nReviewed-by: Mark Mentovai ","shortMessageHtmlLink":"Fix bad pointer comparison"}},{"before":"55036ddccf04ba096c2d133f80a7baf9c0b91e1d","after":"f80f2888031b0570783011476a5e862fb7d848a1","ref":"refs/heads/main","pushedAt":"2024-02-16T02:10:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Fixing integer overflows in Breakpad Processor map/range code.\n\nRecently, Breakpad symbol files have exceeded the various 32-bit limits in these utils and we started seeing integer overflows.\n\nThis is also fixing a build issue in src/common/mac/dump_syms.cc.\n\nChange-Id: Ibd913816c3b2b1171ac9991718c8911ac31eda86\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5299472\nReviewed-by: Ivan Penkov \nReviewed-by: Joshua Peraza ","shortMessageHtmlLink":"Fixing integer overflows in Breakpad Processor map/range code."}},{"before":"6b871f4bd8b6e28191289d19e8ef074a11648a18","after":"55036ddccf04ba096c2d133f80a7baf9c0b91e1d","ref":"refs/heads/main","pushedAt":"2024-02-13T22:52:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Mac: Installer extraction bug fixes\n\n- Mark `RawImagePatch` weak\n- Fix reversed condition in disk image unmounting\n- Ensure source files are closed when copying\n- Use 0-based indexing when determining installer OS version\n\nBug: None\nChange-Id: I015f2b0d9c88a5ec128822d55c974e22723a1a6e\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5291963\nReviewed-by: Mark Mentovai ","shortMessageHtmlLink":"Mac: Installer extraction bug fixes"}},{"before":"38ac9ae56f9a46919f3898aee4c1a8e848e4e197","after":"6b871f4bd8b6e28191289d19e8ef074a11648a18","ref":"refs/heads/main","pushedAt":"2024-02-05T22:43:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Code cleanup for DwarfCUToModule::NullWarningReporter changes.\n\nUpdated code to use Google's modern C++ style.\n\n* Use std::unique_ptr to allocate DwarfCUToModule::WarningReporter.\n* Fixed reference alignment in NullWarningReporter.\n\nChange-Id: I230dac445a07b4023a64284b907010f31eadcdf4\nReviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5265662\nReviewed-by: Lei Zhang \nReviewed-by: Ivan Penkov ","shortMessageHtmlLink":"Code cleanup for DwarfCUToModule::NullWarningReporter changes."}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEUlhGUAA","startCursor":null,"endCursor":null}},"title":"Activity · google/breakpad"}