Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update all package-locks after lerna version #802

Open
rachel-fenichel opened this issue Jul 2, 2021 · 1 comment
Open

update all package-locks after lerna version #802

rachel-fenichel opened this issue Jul 2, 2021 · 1 comment
Labels
type: feature request New feature or request

Comments

@rachel-fenichel
Copy link
Collaborator

Category

Github Action

Component

Is your feature request related to a problem? Please describe.

When releasing samples we sometimes have to update package-lock files by running:
npm run clean:node && npm install

Running this and creating a pull request could be done by an action, manually triggered.

Dependabot tries to take care of package-lock files, but it doesn't handle monorepos well.

Describe the solution you'd like

An action that:

  • Checks out the repository
  • Creates a new branch (package-lock-update-yymmdd)
  • Runs npm install
  • Runs git add plugins/*/package-lock.json
  • Runs git commit -m "Update package-locks"
  • Pushes to google/blockly-samples
  • Opens a PR

Describe alternatives you've considered

Continue doing this manually

Additional context

Here's a starter:

jobs:
  update-package-locks:
    # The type of runner that the job will run on
    runs-on: ubuntu-latest

    # Steps represent a sequence of tasks that will be executed as part of the job
    steps:
      - uses: actions/checkout@v2
      - uses: actions/setup-node@v2
        with:
          node-version: '12'
      - run: npm install
      - run: |
          git add plugins/*/package-lock.json
          git commit -m "Update package-locks"

This doesn't create the new branch or actually push--I ran into questions around auth/whose name goes on the commit.

@rachel-fenichel rachel-fenichel added type: feature request New feature or request triage and removed triage labels Jul 2, 2021
@maribethb
Copy link
Contributor

just found this suggested workaround: lerna/lerna#2891 (comment) we may or may not need this if we get release-please working (dunno is release-please can handle the package-locks being out of sync)

@maribethb maribethb changed the title Action to update all package-locks update all package-locks after lerna version May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants