Should autocxx::c_* newtypes implement Copy?

[WilliamVenner]

Hi,

I noticed that the wrapped C types autocxx exposes do not implement Copy - only Clone, despite most of them having Copy implemented on the underlying type - is this intentional?

autocxx/src/lib.rs

Lines 620 to 633 in 4e96dfd

	macro_rules! ctype_wrapper {
	($r:ident, $c:expr, $d:expr) => {
	#[doc=$d]
	#[derive(Debug, Eq, Clone, PartialEq, Hash)]
	#[allow(non_camel_case_types)]
	#[repr(transparent)]
	pub struct $r(pub ::std::os::raw::$r);
	unsafe impl autocxx_engine::cxx::ExternType for $r {
	type Id = autocxx_engine::cxx::type_id!($c);
	type Kind = autocxx_engine::cxx::kind::Trivial;
	}
	};
	}

Cheers

[adetaylor]

Thanks for the report. These autocxx::c_* types were intended to be a stop-gap measure until dtolnay/cxx#874 lands, which in turn is blocked on dtolnay/cxx#682. There's progress there in dtolnay/cxx#908 thanks to @CAD97 so hopefully these nasty wrappers can go away soon.

However! Meanwhile yes they should probably implement Copy. I'll make that change.