Improve duplicate descriptor checking. #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iptor's for duplicates, remove the ImplementationMethodDescriptor and set the FactoryMethodDescriptor to be overriding and have the same visibility. - The test case, which has been modified to make the concrete class package-private, would not have worked before, because the create methods were given package-private visibility instead of public visibility. - This also makes it so that these duplicate methods have the @OverRide annotation. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=117186640
cgruber
force-pushed
the
internal_duplication_improvement
branch
from
6561434
to
dac3fb5
Compare
|
LGTM |
cgruber
added a commit
that referenced
this pull request
Mar 21, 2016
Improve duplicate descriptor checking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking FactoryMethodDescriptor's and ImplementationMethodDescriptor's for duplicates, remove the ImplementationMethodDescriptor and set the FactoryMethodDescriptor to be overriding and have the same visibility.
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=117186640