Disallow null animations on AnimatedNavHost #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AnimatedNavHost should always provide some value for animations as it is the top of the hierarchy for all destinations. If no animations are desired, then EnterTransition.None or ExitTransition.None should be passed in, not null. Fixes google#856
AnimatedNavHost should not allow you to pass nullables. Ensure that AnimatedNavHost properly goes up the hierarchy to retrieve animations.
ianhanniballake
approved these changes
Nov 13, 2021
hrach
reviewed
Nov 13, 2021
...ation-animation/src/main/java/com/google/accompanist/navigation/animation/AnimatedNavHost.kt
Outdated
Show resolved
Hide resolved
Using firstNotNullOfOrNull in place of mapNotNull and firstOrNull.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AnimatedNavHost should always provide some value for animations as
it is the top of the hierarchy for all destinations. If no animations
are desired, then EnterTransition.None or ExitTransition.None should be
passed in, not null.
Fixes #856