[navigator-animation] popEnterTransition drawn on top of popExitTransition

[brianwernick]

Describe the bug

In navigator-animation when I pop a NavBackStackEntry off the graph and the popExitTransition and popEnterTransition is called the destinations popEnterTransition is drawn over the current (popping) entry's popExitTransition.

To Reproduce

Construct an AnimatedNavHost with a customized popEnterTransition that has an initial offset > 0, e.g.

AnimatedNavHost(
  navController, 
  startDestination = "Blue",
  popEnterTransition = { _, _, ->
    slideInHorizontally(initialOffsetX = { -it / 5 }, animationSpec = tween(durationMillis = 700))
  }
)

NOTE:
If modifying the AnimatedNavHostSample make sure to null out the popEnterTransition of the destination composable, I updated the "Blue" composable to popEnterTransition = null

Expected behavior

The popEnterTransition for the destination NavBackStackEntry should be drawn underneath (lower z-index) the popExitTransition of the current NavBackStackEntry during a pop.

Screenshots?

Environment:

• Android OS version: [Android 10]
• Device: [Emulator]
• Accompanist version: [0.18.0]

[kikasik]

Same issue

[DonnyRozendal]

I have this issue with both entering and popping. This issue is still present on version 0.19.0 and has been an issue since the beginning I believe. This is the only thing that keeps me from using Compose navigation for production...

[ThomasArtProcessors]

Same issue, which is especially jarring when screens slide up and down.
I have a screen that should remain in place with another sliding up from the bottom then sliding down when exiting, but the main screen just appears directly so the slide down is lost.

[alexducatti]

Also confirmed this issue on 0.21.2-beta

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[brianwernick]

Ping for stale bot

[codingfd]

Also confirmed this issue on 0.23.0

[maurycyw]

@jbw0033

could this be as simple as specifying the targetContentZIndex when specifying the transitionSpec for the AnimatedContent? :

meaning instead of

transition.AnimatedContent(
    modifier,
    transitionSpec = { finalEnter(this) with finalExit(this) },
    contentAlignment
) { ... }

we could do:

transition.AnimatedContent(
    modifier,
    transitionSpec = { ContentTransform(finalEnter(this), finalExit(this), 1f) },
    contentAlignment
) { ... }

Also can this ticket please be reopened

[theGlenn]

Quite connected to #1001