Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

targetPage was return currentPage even if currentPageOffset was negative #712

Merged
merged 2 commits into from Sep 13, 2021
Merged

targetPage was return currentPage even if currentPageOffset was negative #712

merged 2 commits into from Sep 13, 2021

Conversation

RareScrap
Copy link
Contributor

fix for #711

@google-cla
Copy link

google-cla bot commented Sep 12, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Sep 12, 2021
@RareScrap
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Sep 12, 2021
@chrisbanes chrisbanes enabled auto-merge (squash) September 13, 2021 09:05
@chrisbanes chrisbanes merged commit 89db790 into google:main Sep 13, 2021
@RareScrap
Copy link
Contributor Author

YAY! My first accepted PR in Google pubpic repo!

@RareScrap RareScrap deleted the pagerstate_targetpage_fix branch September 14, 2021 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants