Fix ANR when showing bottom sheets #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our `internalShow` method could end up in an infinite loop sometimes (yay, recursion!). We now use the official `show` API which *should* work. Unfortunately, our `show` calls all get cancelled but Swipeable still settles in the closest state. This seems to always be the expanded/half-expanded state. We look at the state's targetValue in our try's `finally` block to figure out if the state will settle in an expanded state and call the `onSheetShown` callback based on that. Fixes google#660
jossiwolf
force-pushed
the
anr-when-showing-sheet
branch
from
19e49c5
to
3c6b2d7
Compare
ianhanniballake
approved these changes
Aug 26, 2021
chrisbanes
approved these changes
Aug 26, 2021
|
@ianhanniballake Nope will do that as soon as I get my AndroidX/repo to work again and can file a reliable repro! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
internalShow()method could end up in an infinite loop sometimes (yay, recursion!). We now use the officialshowAPI which should work. Unfortunately, ourshowcalls all get cancelled but Swipeable still settles in the closest state. This seems to always be the expanded/half-expanded state. We look at thesheetState'stargetValuein our try'sfinallyblock to figure out if the state will settle in an expanded state and call theonSheetShowncallback based on that.I'm still investigating why the
showcalls are getting cancelled in the first place and am working on a test for the ANR as well but would like to merge the fix to not keep #660 waiting for too long.Fixes #660