Skip to content

Add minSdk info to AndroidManifest #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Add minSdk info to AndroidManifest #1438

merged 1 commit into from
Dec 8, 2022

Conversation

bentrengrove
Copy link
Collaborator

This makes it easier to import Accompanist into non-gradle build environments

@bentrengrove bentrengrove requested a review from arriolac December 8, 2022 03:24
Copy link

@arriolac arriolac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I counted 30+ AndroidManifest.xml files in the repo though—do we need to do the same for other files?

@bentrengrove
Copy link
Collaborator Author

Only needed for the actual main library implementations

@bentrengrove bentrengrove merged commit 193c640 into main Dec 8, 2022
@bentrengrove bentrengrove deleted the ben/min_sdk branch December 8, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants