Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web] Fix WebView always filling max available space #1397

Merged
merged 2 commits into from Nov 14, 2022

Conversation

bentrengrove
Copy link
Collaborator

Fixes #1297

WebView changes its layout engine based on its layoutParams. This PR converts from a Compose modifier into view layoutParams in order to support this. I thought this was a better integration than simply exposing the layoutParams parameter.

Screenshot_20221114_133703

Copy link
Collaborator

@arriolac arriolac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bentrengrove bentrengrove merged commit 7a293b3 into main Nov 14, 2022
@bentrengrove bentrengrove deleted the ben/webview_layoutparams branch November 14, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebView created with html data always takes up the whole screen
2 participants