[Navigation Animation] Avoid crashing when the start destination changes #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since moving to using visibleEntries, if you change your start destination dynamically, instead of dropping the graph and rebuilding, the AnimatedNavHost crashes. The reason for this crash is that setting the graph synchronously pops the entire back stack, which clears all of the visibleEntries so there is a frame in AnimatedNavHost where it fails to find any of the old entries. We should move setNavGraph over to using the popWithTransition function, but there is pre-req works that needs to be done. So as a stop gap, we will return null from visibleEntries and disable the animations on AnimatedNavHost. Fixes google#1162
bentrengrove
approved these changes
Jul 13, 2022
ianhanniballake
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since moving to using visibleEntries, if you change your start
destination dynamically, instead of dropping the graph and rebuilding,
the AnimatedNavHost crashes.
The reason for this crash is that setting the graph synchronously pops
the entire back stack, which clears all of the visibleEntries so there
is a frame in AnimatedNavHost where it fails to find any of the old
entries.
We should move setNavGraph over to using the popWithTransition function,
but there is pre-req works that needs to be done. So as a stop gap, we
will return null from visibleEntries and disable the animations on
AnimatedNavHost.
Fixes #1162