From dc6e8a2dfa9d8c646a1be2d8c1b7135fd648517c Mon Sep 17 00:00:00 2001 From: Chris Banes Date: Tue, 7 Jul 2020 14:30:12 +0100 Subject: [PATCH 1/2] Call prepareToDraw() to pre-upload Bitmaps to GPU --- coil/src/main/java/dev/chrisbanes/accompanist/coil/Coil.kt | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/coil/src/main/java/dev/chrisbanes/accompanist/coil/Coil.kt b/coil/src/main/java/dev/chrisbanes/accompanist/coil/Coil.kt index 5d03f147f..22c8a11c9 100644 --- a/coil/src/main/java/dev/chrisbanes/accompanist/coil/Coil.kt +++ b/coil/src/main/java/dev/chrisbanes/accompanist/coil/Coil.kt @@ -223,6 +223,12 @@ private fun CoilRequestActor( Coil.imageLoader(transformedRequest.context) .execute(transformedRequest) .toResult() + .also { + // Tell RenderThread to pre-upload this bitmap. Saves the GPU upload cost on the + // first draw. See https://github.com/square/picasso/issues/1620 for a explanation + // from @ChrisCraik + it.image?.prepareToDraw() + } } } From 8b6494ff5b64e02a666742f8af472a979ad0dfb2 Mon Sep 17 00:00:00 2001 From: Chris Banes Date: Tue, 7 Jul 2020 14:52:30 +0100 Subject: [PATCH 2/2] Update to AGP 4.2.0-alpha03 --- .../java/dev/chrisbanes/accompanist/buildsrc/dependencies.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/buildSrc/src/main/java/dev/chrisbanes/accompanist/buildsrc/dependencies.kt b/buildSrc/src/main/java/dev/chrisbanes/accompanist/buildsrc/dependencies.kt index 7736a140d..327c1eb3d 100644 --- a/buildSrc/src/main/java/dev/chrisbanes/accompanist/buildsrc/dependencies.kt +++ b/buildSrc/src/main/java/dev/chrisbanes/accompanist/buildsrc/dependencies.kt @@ -21,7 +21,7 @@ object Versions { } object Libs { - const val androidGradlePlugin = "com.android.tools.build:gradle:4.2.0-alpha02" + const val androidGradlePlugin = "com.android.tools.build:gradle:4.2.0-alpha03" const val gradleMavenPublishPlugin = "com.vanniktech:gradle-maven-publish-plugin:0.11.1"