Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipped midrolls do not play when skipped to the very end of the video duration #10685

Closed
vishnuchilakala opened this issue Oct 13, 2022 · 3 comments
Assignees
Labels

Comments

@vishnuchilakala
Copy link

Use case description

When a user skips to the very end of the video, the IMA sample application plays the last of all the skipped mid rolls by default before considering the playback as ended. The Exoplayer IMA Extension ends the playback instantly, not playing any of the skipped mid rolls.

Proposed solution

On position discontinuity, check if any midrolls have been skipped. If yes, do not send the content complete signal to IMA as of yet.

@vishnuchilakala
Copy link
Author

PR raised for this issue: #10618

@tonihei
Copy link
Collaborator

tonihei commented Oct 17, 2022

I can reproduce the problem, thanks for reporting! Will have a look at the PR and continue the discussion there.

@tonihei
Copy link
Collaborator

tonihei commented Nov 14, 2022

This is now fixed by the PR in #10618

@tonihei tonihei closed this as completed Nov 14, 2022
@google google locked and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants