r2.18.0 #10349
Merged
r2.18.0 #10349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiperOrigin-RevId: 444253425
PiperOrigin-RevId: 444264961
*** Original commit *** Keep AudioTrack on flush as default *** PiperOrigin-RevId: 444327724
30 second clips at higher resolutions are useful for testing encoder behaviour compared to shorter clips. PiperOrigin-RevId: 444505865
30 second clips at higher resolutions are useful for testing encoder behaviour compared to shorter clips. PiperOrigin-RevId: 444505865
This allows the actual bitmap to be saved, even if output dimensions are different than expected. Otherwise, differing output dimensions would throw an exception, preventing the bitmap from being saved. PiperOrigin-RevId: 444512210
This allows the actual bitmap to be saved, even if output dimensions are different than expected. Otherwise, differing output dimensions would throw an exception, preventing the bitmap from being saved. PiperOrigin-RevId: 444512210
Remove unused saveTestBitmapToCacheDirectory throwOnFailure option. #cleanup PiperOrigin-RevId: 444516857
Remove unused saveTestBitmapToCacheDirectory throwOnFailure option. #cleanup PiperOrigin-RevId: 444516857
PiperOrigin-RevId: 444530943
roboletric -> robolectric PiperOrigin-RevId: 440101421
The DefaultMediaNotificationProvider checks if a command is available before putting the respective action in the notification. PiperOrigin-RevId: 440114422
The MIME type was set to H265 to force transcoding. Now that we have an encoder factory that forces encoding, switching back to H264 ensures the quality test is conducted on more devices (those don't support H265 can be tested now). However, H265 should be part of the quality test after we have proper mechanism to skip test based on device capability. PiperOrigin-RevId: 440132471
PiperOrigin-RevId: 440325693
PiperOrigin-RevId: 440347550
PiperOrigin-RevId: 440378974
PiperOrigin-RevId: 441142050
Transformer resolves to null when wrapped, this is a debug line that was not removed. PiperOrigin-RevId: 441200790
PiperOrigin-RevId: 441230941
1. TracksInfo is renamed to Tracks 2. TracksInfo.TrackGroupInfo is renamed to Tracks.Group PiperOrigin-RevId: 441232373
PiperOrigin-RevId: 441250773
…troller-release PiperOrigin-RevId: 441253378
The stream with the mp3 track is added because - We only encode to AAC - We only encode when the source track is not AAC Now that we have a way to force encoding, we no longer need the mp3 track. The test asset is kept for later parameterized testing. PiperOrigin-RevId: 440876080
PiperOrigin-RevId: 441424063
What a minimal implementation should include is now explained in the interface javadoc while the method name reflects what the method does. PiperOrigin-RevId: 441432059
Scaling and rotation using ScaleToFitFrameProcessor may change the the resolution and aspect ratio, so defaulting to the same as the input is no longer accurate. PiperOrigin-RevId: 441463349
* Group what's now many related test PNGs by moving them to their own directory. * Move bitmap references to files where they're used, as each bitmap is only used once each, except the original bitmap. PiperOrigin-RevId: 441485489
PiperOrigin-RevId: 440906834
PiperOrigin-RevId: 441712166
The current setup with distinct, private `keyForField` implementations, leaves open the (theoretical) possibility of a clash in the `Bundle` keys used by the superclass and subclass. This change brings consistency with our only other extensible `Bundleable` type (`PlaybackException`). #minor-release PiperOrigin-RevId: 453385875 (cherry picked from commit a056f08)
PiperOrigin-RevId: 453490088 (cherry picked from commit ade3452)
#minor-release PiperOrigin-RevId: 453622964 (cherry picked from commit 2c2be2d)
With HLS chunkless preparation, audio formats may have no value for channel count. In this case, the DefaultAudioSink will either query the platform for a supported channel count (API 29+) or assume a max channel count based on the encoding spec in order to decide whether the audio format can be played with audio passthrough. Issue: #10204 #minor-release PiperOrigin-RevId: 453644548 (cherry picked from commit b3b57bc)
Some Player implementations have no playlist capability but can still set a MediaItem for playback. Examples are a MediaController connected to a legacy MediaSession, ExoPlayer up to 2.12 or MediaPlayer. To indicate this capability, we need an allowed command in addition to COMMAND_CHANGE_MEDIA_ITEMS that just allows to set a single item that replaces everything that is currently played. #minor-release PiperOrigin-RevId: 453879626 (cherry picked from commit 2056152)
PiperOrigin-RevId: 453905355 (cherry picked from commit 8a31e33)
This change fixes a bug where the player is frozen with HLS chunkless preparation because the audio stream wrappers are not marked as master timestamp sources before preparation. #minor-release PiperOrigin-RevId: 453941815 (cherry picked from commit 9174841)
#minor-release PiperOrigin-RevId: 453408087 (cherry picked from commit 527db57)
The track selector will select multi-channel formats when those can be spatialized, otherwise the selector will prefer stereo/mono audio tracks. When the device supports audio spatialization (Android 12L+), the DefaultTrackSelector will monitor for changes in the platform Spatializer and trigger a new track selection upon a Spatializer change event. Devices with a `television` UI mode are excluded from audio channel count constraints. #minor-release PiperOrigin-RevId: 453957269 (cherry picked from commit 9f3c595)
`codecDrainAction` is set to `DRAIN_ACTION_NONE` in 3 places in `MediaCodecRenderer`: * The constructor (so there's no prior state to worry about) * `updateDrmSessionV23()`: Where `mediaCrypto` is reconfigured based on `sourceDrmSession` and `codecDrmSession` is also updated to `sourceDrmSession`. * `resetCodecStateForFlush()`: Where (before this change) the action is unconditionally set back to `DRAIN_ACTION_NONE` and so any required updated implied by `DRAIN_ACTION_FLUSH_AND_UPDATE_DRM_SESSION` is not done. This change ensures that `flushOrReleaseCodec()` handles `DRAIN_ACTION_FLUSH_AND_UPDATE_DRM_SESSION` before calling . This probably also resolves Issue: #10274 #minor-release PiperOrigin-RevId: 454114428 (cherry picked from commit c736a72)
The default constructor is only allowed to be called on API < 32 and the test should use the defined UNSET constant to be API independent. #minor-release PiperOrigin-RevId: 454568893 (cherry picked from commit 0ed5321)
PiperOrigin-RevId: 454641746 (cherry picked from commit 1c373d5)
#minor-release PiperOrigin-RevId: 454884692 (cherry picked from commit 6dc4b39)
PiperOrigin-RevId: 454939082 (cherry picked from commit d1fbef8)
PiperOrigin-RevId: 454945333 (cherry picked from commit 4759472)
See https://issuetracker.google.com/208178382 PiperOrigin-RevId: 454949204 (cherry picked from commit 6fd777c)
PiperOrigin-RevId: 454951844 (cherry picked from commit 8b65c6a)
PiperOrigin-RevId: 455094147 (cherry picked from commit 1ca382d)
#minor-release PiperOrigin-RevId: 455128997 (cherry picked from commit 499d3f9)
#minor-release PiperOrigin-RevId: 455140203 (cherry picked from commit 05b69a7)
PiperOrigin-RevId: 455347182 (cherry picked from commit e220f53)
#minor-release PiperOrigin-RevId: 455350486 (cherry picked from commit 209d308)
Fixing lint errors in the string.xml files makes no sense because these are overridden with the next automated string import. Adding a lint-baseline.xml instead for the ui module. See https://issuetracker.google.com/208178382 #minor-release PiperOrigin-RevId: 455354304 (cherry picked from commit 495480a)
#minor-release PiperOrigin-RevId: 455361427 (cherry picked from commit 87420fc)
#minor-release PiperOrigin-RevId: 455372269 (cherry picked from commit 71ae88f)
The API 32 SDK has incorrect versioning metadata for Spatializer. It reports the whole class has only been present since API 33 (which is surely impossible given it's present in the API 32 SDK): https://issuetracker.google.com/234009300 The metadata seems to be correct in the API 33 SDK, so this baseline will no longer be needed when we bump to `compileSdkVersion = 33`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.