Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selected speed option is not identified by TalkBack #10298

Closed
1 task
hshapley opened this issue May 26, 2022 · 2 comments
Closed
1 task

Selected speed option is not identified by TalkBack #10298

hshapley opened this issue May 26, 2022 · 2 comments
Assignees
@icbaker
Labels
bug needs triage

Comments

@hshapley
Copy link

ExoPlayer Version

2.17.1

Devices that reproduce the issue

All devices tested so far: Pixel 2 XL (Android 11), Pixel 4 (Android 12), OnePlus Nord CE 2 Lite

Devices that do not reproduce the issue

No response

Reproducible in the demo app?

Not tested

Reproduction steps

  1. Enable TalkBack on the device
  2. Open a video in ExoPlayer
  3. Open the controls and select Settings, then Speed
  4. Listen to the announced selection, and swipe through to "Normal"

Expected result

  • Normal should have focus by default
  • TalkBack should read "Normal - Selected" or "Normal - Checked"

Actual result

  • The lowest speed option has focus by default
  • When focus is moved to the selected option (Normal), it says "Normal - Double tap to activate". Which is incorrect, because it is already selected.

Media

https://www.sample-videos.com/video123/mp4/480/big_buck_bunny_480p_2mb.mp4

Bug Report
@christosts christosts self-assigned this May 27, 2022
@christosts
Copy link
Contributor

I can see this also occurs on the demo app. @icbaker will you able to take a look whether there is something in the UI elements that need to change?

@christosts christosts assigned icbaker and unassigned christosts May 27, 2022
marcbaechinger pushed a commit to androidx/media that referenced this issue Jul 4, 2022
@icbaker @marcbaechinger
Ensure TalkBack announces the selected playback speed in the UI menu
3fc6a66 
Issue: google/ExoPlayer#10298
#minor-release
PiperOrigin-RevId: 457991028
rohitjoins pushed a commit that referenced this issue Jul 7, 2022
@icbaker @rohitjoins
Ensure TalkBack announces the selected playback speed in the UI menu
bf86b60 
Issue: #10298
#minor-release
PiperOrigin-RevId: 457991028
@tonihei
Copy link
Collaborator

tonihei commented Jul 15, 2022

Fixed by the commit above.

@tonihei tonihei closed this as completed Jul 15, 2022
rohitjoins pushed a commit that referenced this issue Jul 15, 2022
@icbaker @rohitjoins
Ensure TalkBack announces the selected playback speed in the UI menu
315bf6b 
Issue: #10298
#minor-release
PiperOrigin-RevId: 457991028
(cherry picked from commit bf86b60)
rohitjoins pushed a commit to androidx/media that referenced this issue Jul 15, 2022
@icbaker @rohitjoins
Ensure TalkBack announces the selected playback speed in the UI menu
258d936 
Issue: google/ExoPlayer#10298
PiperOrigin-RevId: 457991028
(cherry picked from commit 3fc6a66)
@google google locked and limited conversation to collaborators Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@icbaker icbaker

Labels
bug needs triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hshapley @icbaker @tonihei @christosts