Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing sideloading subtitle track with hls contents, video/audio renderers are resetted for a while #10248

Closed
HyowonHwang opened this issue May 9, 2022 · 3 comments
Assignees
Labels

Comments

@HyowonHwang
Copy link

HyowonHwang commented May 9, 2022

ExoPlayer Version

2.17.1

Devices that reproduce the issue

Samsung Z Flip3 os 12
All devices.

Devices that do not reproduce the issue

No response

Reproducible in the demo app?

Yes

Reproduction steps

  1. Add information of external subtitle to any hls contents in media.exolist.json
{
      "name": "Apple multivariant playlist advanced (TS)",
      "uri": "https://devstreaming-cdn.apple.com/videos/streaming/examples/img_bipbop_adv_example_ts/master.m3u8",
      "subtitle_uri": "https://storage.googleapis.com/exoplayer-test-media-1/webvtt/numeric-lines.vtt",
      "subtitle_mime_type": "text/vtt",
      "subtitle_language": "en"
    }
  1. Change text track to external subtitle.
  2. Player state change to Buffering -> Ready shortly.

Expected result

It should change without reset of audio/video renderers.

This only happen playing external subtitles when playing hls contents.

With 2.16.0 release, it goes well.

Actual result

Audio/Video renderers are resetted for a while.

Media

Modify media from demo app

{
      "name": "Apple multivariant playlist advanced (TS)",
      "uri": "https://devstreaming-cdn.apple.com/videos/streaming/examples/img_bipbop_adv_example_ts/master.m3u8",
      "subtitle_uri": "https://storage.googleapis.com/exoplayer-test-media-1/webvtt/numeric-lines.vtt",
      "subtitle_mime_type": "text/vtt",
      "subtitle_language": "en"
    }

Bug Report

@HyowonHwang HyowonHwang changed the title Changing external text track with hls contents, video/audio renderers are resetted Changing sideloading subtitle track with hls contents, video/audio renderers are resetted for a while May 9, 2022
@tonihei tonihei self-assigned this May 16, 2022
@tonihei
Copy link
Collaborator

tonihei commented May 17, 2022

Thanks for reporting! This is indeed a bug we introduced in 2.17.0 caused by a missing equals method. We'll provide a fix in the next release.

@HyowonHwang
Copy link
Author

@tonihei Thanks for response. I will check it again with next release.

icbaker pushed a commit to androidx/media that referenced this issue May 24, 2022
This causes a bug where the forwarded selections are no longer
assumed equal and the child MediaPeriods will think they need
to reset streams even though the selection stayed the same.

Issue: Issue: google/ExoPlayer#10248
PiperOrigin-RevId: 449454038
icbaker pushed a commit that referenced this issue May 24, 2022
This causes a bug where the forwarded selections are no longer
assumed equal and the child MediaPeriods will think they need
to reset streams even though the selection stayed the same.

Issue: Issue: #10248
PiperOrigin-RevId: 449454038
@tonihei
Copy link
Collaborator

tonihei commented Jun 9, 2022

This is fixed by the commit above.

@tonihei tonihei closed this as completed Jun 9, 2022
@google google locked and limited conversation to collaborators Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants