Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DASH DTS Digital Surround Passthrough Fails in recent Exoplayer Versions. #10159

Closed
1 task
cedricxperi opened this issue Apr 7, 2022 · 3 comments
Closed
1 task
Assignees
Labels

Comments

@cedricxperi
Copy link
Contributor

cedricxperi commented Apr 7, 2022

ExoPlayer Version

2.17.1

Devices that reproduce the issue

Nvidia Shield TV Pro

Devices that do not reproduce the issue

None

Reproducible in the demo app?

Yes

Reproduction steps

Playback a DASH DTS Digital Surround audio stream on Nvidia Shield TV Pro (connected to an AVR via HDMI) running v2.17.1 Exoplayer demo app.
The DTS bitstream should be passthrough to the AVR for decoding. This works in earlier versions of Exoplayer, E.g. v2.11.8. In v2.17.1 the playback stops with a warning message, "Media includes audio tracks, but none are playable by this device".

Solution: To fix this issue, add the following to DashManifestParser.parseAudioChannelConfiguration()

  case "urn:dts:dash:audio_channel_configuration:2012":
  case "tag:dts.com,2014:dash:audio_channel_configuration:2012":
  case "tag:dts.com,2018:uhd:audio_channel_configuration":
    audioChannels = parseDtsChannelConfiguration(xpp);
    break;

These are defined in DASH-IF guidelines: https://dashif.org/docs/Audio%20Amendment%20to%20DASH%20IOP%204.3.pdf

Expected result

The DTS bitstream should be passthrough to the AVR for decoding.

Actual result

Playback stops with a warning message, "Media includes audio tracks, but none are playable by this device"

Media

Test media and code for parseDtsChannelConfiguration(xpp) will be emailed to dev.exoplayer@gmail.com

Bug Report

@ojw28
Copy link
Contributor

ojw28 commented Apr 19, 2022

Thanks for the detailed report and proposed fix!

@cedricxperi
Copy link
Contributor Author

No worries. Thanks for looking in to this!

@ojw28
Copy link
Contributor

ojw28 commented Apr 20, 2022

Please see email. Thanks!

cedricxperi added a commit to cedricxperi/ExoPlayer that referenced this issue Apr 22, 2022
@ojw28 ojw28 closed this as completed Apr 26, 2022
@google google locked and limited conversation to collaborators Jun 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants