Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: point users to specific example workflow #254

Merged
merged 2 commits into from Dec 22, 2020
Merged

fix: point users to specific example workflow #254

merged 2 commits into from Dec 22, 2020

Conversation

averikitsch
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes label Dec 21, 2020
@averikitsch averikitsch changed the title fix: point users to Cloud Run example workflow fix: point users to specific example workflow Dec 22, 2020
bharathkkb
bharathkkb reviewed Dec 22, 2020
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some of the files were removed which may prevent the workflow from being functional out of the box?

example-workflows/cloud-run/README.md Show resolved Hide resolved
example-workflows/cloud-run/cloud-run.yml Show resolved Hide resolved
@averikitsch
Copy link
Contributor Author

Looks like some of the files were removed which may prevent the workflow from being functional out of the box?

I'm debating here not having the full example app but just showing the workflow file. I am trying to push people towards the specific actions. The "workflow description" just describes what is happening in the file.

bharathkkb
bharathkkb approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@averikitsch I see, in that case LGTM

@averikitsch averikitsch merged commit 99f25f1 into master Dec 22, 2020
@averikitsch averikitsch deleted the workflows branch December 22, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@averikitsch @bharathkkb