Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: surface underlying error for slice / map helpers #580

Merged
merged 1 commit into from Jan 4, 2022

Conversation

stevenh
Copy link
Collaborator

@stevenh stevenh commented Nov 3, 2021

Surface the underlying error when processing results for slice and map helpers so that the user can see the real cause and not a type mismatch error.

Also:

  • Formatting changes to improve error case separation.
  • Leverage %w in reply errors.

Fixes: #579

Surface the underlying error when processing results for slice and map
helpers so that the user can see the real cause and not a type mismatch
error.

Also:
* Formatting changes to improve error case separation.
* Leverage %w in reply errors.

Fixes: #579
@stevenh stevenh marked this pull request as ready for review December 31, 2021 20:48
@stevenh stevenh merged commit a83ebbe into master Jan 4, 2022
@stevenh stevenh deleted the slice-errors branch January 4, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reply.go sliceHelper does not handle Redis errors within the slice
1 participant