Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix do script issue on convert error failed #563

Merged
merged 1 commit into from Jul 1, 2022
Merged

Fix do script issue on convert error failed #563

merged 1 commit into from Jul 1, 2022

Conversation

wenpeng
Copy link
Contributor

@wenpeng wenpeng commented May 31, 2021

No description provided.

stevenh
stevenh requested changes Jun 4, 2021
View reviewed changes
Copy link
Collaborator

@stevenh stevenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide a test case which demonstrates this failure please.

@stevenh
Copy link
Collaborator

stevenh commented Sep 30, 2021

Hi @wenpeng did you have chance to look at adding a test for this?

@stevenh stevenh merged commit d3b4cc3 into gomodule:master Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenh stevenh stevenh approved these changes

Assignees
No one assigned
Labels
Waiting for response
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wenpeng @stevenh