Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass context to TestOnBorrow #439

Open
dcormier opened this issue Oct 7, 2019 · 4 comments
Open

Pass context to TestOnBorrow #439

dcormier opened this issue Oct 7, 2019 · 4 comments

Comments

@dcormier
Copy link
Contributor

dcormier commented Oct 7, 2019

I like to add tracing to my code. This depends on being able to pass a context around. To that end, I wish TestOnBorrow was passed the context that's passed to GetContext. Perhaps this would require a new function so it's not a breaking change: TestOnBorrowContext, or something similar.

@stevenh
Copy link
Collaborator

stevenh commented Oct 11, 2019

Indeed this would require a new method.

@dcormier
Copy link
Contributor Author

dcormier commented Apr 10, 2020

Uh, so, was a new method added? The PR was closed without merging, resulting in this issue being closed. And I don't have permissions to reopen the issue.

@stevenh
Copy link
Collaborator

stevenh commented Apr 10, 2020

Yes you can see the comments on the #442

@stevenh stevenh reopened this Apr 13, 2020
@stevenh
Copy link
Collaborator

stevenh commented Jan 28, 2024

@dcormier just flagging this was reopened in case you didn't see the notification.

Also mentioning that I'm thinking of a v2 which would help clean up the existing interfaces, so would be interested in peoples feedback on use cases like this we should consider when designing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants