forked from jsx-eslint/eslint-plugin-react
/
no-redundant-should-component-update.js
153 lines (144 loc) · 3.3 KB
/
no-redundant-should-component-update.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
/**
* @fileoverview Tests for no-redundant-should-component-update
*/
'use strict';
// -----------------------------------------------------------------------------
// Requirements
// -----------------------------------------------------------------------------
const RuleTester = require('eslint').RuleTester;
const rule = require('../../../lib/rules/no-redundant-should-component-update');
const parsers = require('../../helpers/parsers');
const parserOptions = {
ecmaVersion: 2018,
ecmaFeatures: {
jsx: true
}
};
function errorMessage(node) {
return `${node} does not need shouldComponentUpdate when extending React.PureComponent.`;
}
// -----------------------------------------------------------------------------
// Tests
// -----------------------------------------------------------------------------
const ruleTester = new RuleTester();
ruleTester.run('no-redundant-should-component-update', rule, {
valid: [
{
code: `
class Foo extends React.Component {
shouldComponentUpdate() {
return true;
}
}
`,
parserOptions
},
{
code: `
class Foo extends React.Component {
shouldComponentUpdate() {
return true;
}
}
`,
parserOptions,
parser: parsers.BABEL_ESLINT
},
{
code: `
class Foo extends React.Component {
shouldComponentUpdate = () => {
return true;
}
}
`,
parser: parsers.BABEL_ESLINT,
parserOptions
},
{
code: `
function Foo() {
return class Bar extends React.Component {
shouldComponentUpdate() {
return true;
}
};
}
`,
parserOptions
}
],
invalid: [
{
code: `
class Foo extends React.PureComponent {
shouldComponentUpdate() {
return true;
}
}
`,
errors: [{message: errorMessage('Foo')}],
parserOptions
},
{
code: `
class Foo extends PureComponent {
shouldComponentUpdate() {
return true;
}
}
`,
errors: [{message: errorMessage('Foo')}],
parserOptions
},
{
code: `
class Foo extends React.PureComponent {
shouldComponentUpdate = () => {
return true;
}
}
`,
errors: [{message: errorMessage('Foo')}],
parser: parsers.BABEL_ESLINT,
parserOptions
},
{
code: `
function Foo() {
return class Bar extends React.PureComponent {
shouldComponentUpdate() {
return true;
}
};
}
`,
errors: [{message: errorMessage('Bar')}],
parserOptions
},
{
code: `
function Foo() {
return class Bar extends PureComponent {
shouldComponentUpdate() {
return true;
}
};
}
`,
errors: [{message: errorMessage('Bar')}],
parserOptions
},
{
code: `
var Foo = class extends PureComponent {
shouldComponentUpdate() {
return true;
}
}
`,
errors: [{message: errorMessage('Foo')}],
parserOptions
}
]
});