Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nil handling for Call() #40

Merged
merged 2 commits into from Apr 16, 2022
Merged

nil handling for Call() #40

merged 2 commits into from Apr 16, 2022

Conversation

Place1
Copy link
Contributor

@Place1 Place1 commented Apr 16, 2022

No description provided.

@Place1
Copy link
Contributor Author

Place1 commented Apr 16, 2022

Just a follow up. If the receiver returns nil then that's technically not an error type at runtime when using the relect package meaning result[0].Interface().(error) is an invalid cast for a nil value.

This PR adds explicit handling for it.

@miladrahimi miladrahimi merged commit 9432853 into golobby:master Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Place1 @miladrahimi