From 498f91a6ff8a37162afc7d6c85e5c119e1f0be42 Mon Sep 17 00:00:00 2001 From: Kir Kolyshkin Date: Wed, 3 Aug 2022 16:49:37 -0700 Subject: [PATCH 1/2] ci/gha: remove stable from actions/setup-go Since actions/setup-go v3 this parameter is no longer required (see https://github.com/actions/setup-go/releases/tag/v3.0.0). Signed-off-by: Kir Kolyshkin --- .github/workflows/post-release.yml | 3 --- .github/workflows/pr-extra.yml | 3 --- .github/workflows/pr.yml | 18 ------------------ .github/workflows/tag.yml | 6 ------ 4 files changed, 30 deletions(-) diff --git a/.github/workflows/post-release.yml b/.github/workflows/post-release.yml index 91da23b43b00..be4909fefb8f 100644 --- a/.github/workflows/post-release.yml +++ b/.github/workflows/post-release.yml @@ -14,9 +14,6 @@ jobs: - name: Install Go uses: actions/setup-go@v3 with: - # Keep the following comment to be able to use rc and beta version of Go (ex: 1.18.0-rc.1). - # https://github.com/actions/setup-go#supported-version-syntax - # stable: 'false' go-version: 1.19 - name: Update GitHub action config diff --git a/.github/workflows/pr-extra.yml b/.github/workflows/pr-extra.yml index 1552d4ea194e..a3865dbd906c 100644 --- a/.github/workflows/pr-extra.yml +++ b/.github/workflows/pr-extra.yml @@ -13,9 +13,6 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-go@v3 with: - # Keep the following comment to be able to use rc and beta version of Go (ex: 1.18.0-rc.1). - # https://github.com/actions/setup-go#supported-version-syntax - # stable: 'false' go-version: 1.19 - name: Run go list run: go list -json -m all > go.list diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index cd3ea3b151f0..3d8ce2ce1a22 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -16,9 +16,6 @@ jobs: - name: Install Go uses: actions/setup-go@v3 with: - # Keep the following comment to be able to use rc and beta version of Go (ex: 1.18.0-rc.1). - # https://github.com/actions/setup-go#supported-version-syntax - # stable: 'false' go-version: ${{ env.GO_VERSION }} - name: Checkout code uses: actions/checkout@v3 @@ -36,9 +33,6 @@ jobs: - name: Install Go uses: actions/setup-go@v3 with: - # Keep the following comment to be able to use rc and beta version of Go (ex: 1.18.0-rc.1). - # https://github.com/actions/setup-go#supported-version-syntax - # stable: 'false' # go-version: ${{ env.GO_VERSION }} # todo(ldez) uncomment after the next release v1.48.0 go-version: 1.18 - name: lint @@ -57,9 +51,6 @@ jobs: - name: Install Go uses: actions/setup-go@v3 with: - # Keep the following comment to be able to use rc and beta version of Go (ex: 1.18.0-rc.1). - # https://github.com/actions/setup-go#supported-version-syntax - # stable: 'false' go-version: ${{ env.GO_VERSION }} # test only the latest go version to speed up CI - name: Run tests run: make.exe test @@ -73,9 +64,6 @@ jobs: - name: Install Go uses: actions/setup-go@v3 with: - # Keep the following comment to be able to use rc and beta version of Go (ex: 1.18.0-rc.1). - # https://github.com/actions/setup-go#supported-version-syntax - # stable: 'false' go-version: ${{ env.GO_VERSION }} # test only the latest go version to speed up CI - name: Run tests run: make test @@ -93,9 +81,6 @@ jobs: - name: Install Go uses: actions/setup-go@v3 with: - # Keep the following comment to be able to use rc and beta version of Go (ex: 1.18.0-rc.1). - # https://github.com/actions/setup-go#supported-version-syntax - # stable: 'false' go-version: ${{ matrix.golang }} - uses: actions/cache@v3 with: @@ -119,9 +104,6 @@ jobs: - name: Install Go uses: actions/setup-go@v3 with: - # Keep the following comment to be able to use rc and beta version of Go (ex: 1.18.0-rc.1). - # https://github.com/actions/setup-go#supported-version-syntax - # stable: 'false' go-version: ${{ env.GO_VERSION }} - name: Check generated files are up to date run: make fast_check_generated diff --git a/.github/workflows/tag.yml b/.github/workflows/tag.yml index b31c82bbdf73..6ef4f120eb83 100644 --- a/.github/workflows/tag.yml +++ b/.github/workflows/tag.yml @@ -14,9 +14,6 @@ jobs: - name: Install Go uses: actions/setup-go@v3 with: - # Keep the following comment to be able to use rc and beta version of Go (ex: 1.18.0-rc.1). - # https://github.com/actions/setup-go#supported-version-syntax - # stable: 'false' go-version: 1.19 - name: Unshallow run: git fetch --prune --unshallow @@ -43,9 +40,6 @@ jobs: - name: Install Go uses: actions/setup-go@v3 with: - # Keep the following comment to be able to use rc and beta version of Go (ex: 1.18.0-rc.1). - # https://github.com/actions/setup-go#supported-version-syntax - # stable: 'false' go-version: 1.19 - name: Unshallow From 4758343caf80b349f2984ec1ea3886f911bccd90 Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Thu, 4 Aug 2022 03:14:36 +0200 Subject: [PATCH 2/2] reveiw --- .github/workflows/post-release.yml | 4 ++++ .github/workflows/pr-extra.yml | 4 ++++ .github/workflows/pr.yml | 24 ++++++++++++++++++++++++ .github/workflows/tag.yml | 8 ++++++++ 4 files changed, 40 insertions(+) diff --git a/.github/workflows/post-release.yml b/.github/workflows/post-release.yml index be4909fefb8f..d00c7a095cfd 100644 --- a/.github/workflows/post-release.yml +++ b/.github/workflows/post-release.yml @@ -14,6 +14,10 @@ jobs: - name: Install Go uses: actions/setup-go@v3 with: + # https://github.com/actions/setup-go#supported-version-syntax + # ex: + # - 1.18beta1 -> 1.18.0-beta.1 + # - 1.18rc1 -> 1.18.0-rc.1 go-version: 1.19 - name: Update GitHub action config diff --git a/.github/workflows/pr-extra.yml b/.github/workflows/pr-extra.yml index a3865dbd906c..2b3016ab5d3d 100644 --- a/.github/workflows/pr-extra.yml +++ b/.github/workflows/pr-extra.yml @@ -13,6 +13,10 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-go@v3 with: + # https://github.com/actions/setup-go#supported-version-syntax + # ex: + # - 1.18beta1 -> 1.18.0-beta.1 + # - 1.18rc1 -> 1.18.0-rc.1 go-version: 1.19 - name: Run go list run: go list -json -m all > go.list diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 3d8ce2ce1a22..b067e7644034 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -16,6 +16,10 @@ jobs: - name: Install Go uses: actions/setup-go@v3 with: + # https://github.com/actions/setup-go#supported-version-syntax + # ex: + # - 1.18beta1 -> 1.18.0-beta.1 + # - 1.18rc1 -> 1.18.0-rc.1 go-version: ${{ env.GO_VERSION }} - name: Checkout code uses: actions/checkout@v3 @@ -33,6 +37,10 @@ jobs: - name: Install Go uses: actions/setup-go@v3 with: + # https://github.com/actions/setup-go#supported-version-syntax + # ex: + # - 1.18beta1 -> 1.18.0-beta.1 + # - 1.18rc1 -> 1.18.0-rc.1 # go-version: ${{ env.GO_VERSION }} # todo(ldez) uncomment after the next release v1.48.0 go-version: 1.18 - name: lint @@ -51,6 +59,10 @@ jobs: - name: Install Go uses: actions/setup-go@v3 with: + # https://github.com/actions/setup-go#supported-version-syntax + # ex: + # - 1.18beta1 -> 1.18.0-beta.1 + # - 1.18rc1 -> 1.18.0-rc.1 go-version: ${{ env.GO_VERSION }} # test only the latest go version to speed up CI - name: Run tests run: make.exe test @@ -64,6 +76,10 @@ jobs: - name: Install Go uses: actions/setup-go@v3 with: + # https://github.com/actions/setup-go#supported-version-syntax + # ex: + # - 1.18beta1 -> 1.18.0-beta.1 + # - 1.18rc1 -> 1.18.0-rc.1 go-version: ${{ env.GO_VERSION }} # test only the latest go version to speed up CI - name: Run tests run: make test @@ -81,6 +97,10 @@ jobs: - name: Install Go uses: actions/setup-go@v3 with: + # https://github.com/actions/setup-go#supported-version-syntax + # ex: + # - 1.18beta1 -> 1.18.0-beta.1 + # - 1.18rc1 -> 1.18.0-rc.1 go-version: ${{ matrix.golang }} - uses: actions/cache@v3 with: @@ -104,6 +124,10 @@ jobs: - name: Install Go uses: actions/setup-go@v3 with: + # https://github.com/actions/setup-go#supported-version-syntax + # ex: + # - 1.18beta1 -> 1.18.0-beta.1 + # - 1.18rc1 -> 1.18.0-rc.1 go-version: ${{ env.GO_VERSION }} - name: Check generated files are up to date run: make fast_check_generated diff --git a/.github/workflows/tag.yml b/.github/workflows/tag.yml index 6ef4f120eb83..c2bb3e6c6047 100644 --- a/.github/workflows/tag.yml +++ b/.github/workflows/tag.yml @@ -14,6 +14,10 @@ jobs: - name: Install Go uses: actions/setup-go@v3 with: + # https://github.com/actions/setup-go#supported-version-syntax + # ex: + # - 1.18beta1 -> 1.18.0-beta.1 + # - 1.18rc1 -> 1.18.0-rc.1 go-version: 1.19 - name: Unshallow run: git fetch --prune --unshallow @@ -40,6 +44,10 @@ jobs: - name: Install Go uses: actions/setup-go@v3 with: + # https://github.com/actions/setup-go#supported-version-syntax + # ex: + # - 1.18beta1 -> 1.18.0-beta.1 + # - 1.18rc1 -> 1.18.0-rc.1 go-version: 1.19 - name: Unshallow