From 30cbe83b4390e878a1f2072aed26c4d992619464 Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Sun, 14 Mar 2021 22:37:17 +0100 Subject: [PATCH 1/3] fix: remove useless conditions. --- pkg/lint/linter/config.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/lint/linter/config.go b/pkg/lint/linter/config.go index 86f78e5a4b8e..3dadd30a8d48 100644 --- a/pkg/lint/linter/config.go +++ b/pkg/lint/linter/config.go @@ -35,7 +35,7 @@ func (lc *Config) ConsiderSlow() *Config { } func (lc *Config) IsSlowLinter() bool { - return lc.IsSlow || (lc.LoadMode&packages.NeedTypesInfo != 0 && lc.LoadMode&packages.NeedDeps != 0) + return lc.IsSlow } func (lc *Config) WithLoadFiles() *Config { From 15f95809d522bfa03fc150be49560c60af7b6977 Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Sun, 14 Mar 2021 22:37:48 +0100 Subject: [PATCH 2/3] feat: considere revive as slow. --- pkg/lint/lintersdb/manager.go | 1 + 1 file changed, 1 insertion(+) diff --git a/pkg/lint/lintersdb/manager.go b/pkg/lint/lintersdb/manager.go index b8a84ac973a6..50083fa36a6f 100644 --- a/pkg/lint/lintersdb/manager.go +++ b/pkg/lint/lintersdb/manager.go @@ -376,6 +376,7 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config { WithURL("https://github.com/nishanths/predeclared"), linter.NewConfig(golinters.NewRevive(reviveCfg)). WithPresets(linter.PresetStyle). + ConsiderSlow(). WithURL("https://github.com/mgechev/revive"), linter.NewConfig(golinters.NewDurationCheck()). WithPresets(linter.PresetBugs). From 51de3911a5f170e31534fa3ba064c9129c8dfe11 Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Sun, 14 Mar 2021 22:38:57 +0100 Subject: [PATCH 3/3] feat: considere linters with go analysis as slow. --- pkg/lint/linter/config.go | 1 + 1 file changed, 1 insertion(+) diff --git a/pkg/lint/linter/config.go b/pkg/lint/linter/config.go index 3dadd30a8d48..d69d9144a779 100644 --- a/pkg/lint/linter/config.go +++ b/pkg/lint/linter/config.go @@ -46,6 +46,7 @@ func (lc *Config) WithLoadFiles() *Config { func (lc *Config) WithLoadForGoAnalysis() *Config { lc = lc.WithLoadFiles() lc.LoadMode |= packages.NeedImports | packages.NeedDeps | packages.NeedExportsFile | packages.NeedTypesSizes + lc.IsSlow = true return lc }